Add Auto Review proof metrics fixture#414
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
approvals_revieweroncode exec --jsonthread.startedevents so CLI fixtures can validate reviewer routing directlyapprovals_reviewer = "auto_review"is accepted and emitted through the current wire-compatibleguardian_subagentspellingValidation
python3 -m json.tool tools/code-exec-harness/scenarios/auto-review-config-routing.json >/dev/nullpython3 -m py_compile tools/code-exec-harness/harness.pygit diff --check./build-fast.shpython3 tools/code-exec-harness/harness.py tools/code-exec-harness/scenarios/auto-review-config-routing.json --code-bin /Users/cbusillo/.code/worktrees/code/auto-review-proof-metrics/code-rs/target/dev-fast/codeCODE_EXEC_HARNESS_BIN=/Users/cbusillo/.code/worktrees/code/auto-review-proof-metrics/code-rs/target/dev-fast/code tools/code-exec-harness/run-deterministic.shNotes
398c40ae-0323-4e2b-9e01-46fbb80e8d01failed before findings because the diff was 1,479,472 chars against the 120,000-char configured background review limit.Closes #400.