Skip to content

Validate App Store review dry-run version state#138

Merged
cbusillo merged 1 commit into
mainfrom
fix/app-store-review-dry-run-version-state
Jun 7, 2026
Merged

Validate App Store review dry-run version state#138
cbusillo merged 1 commit into
mainfrom
fix/app-store-review-dry-run-version-state

Conversation

@cbusillo
Copy link
Copy Markdown
Owner

@cbusillo cbusillo commented Jun 7, 2026

Summary

  • make App Store review dry-runs validate the version path before apply mode
  • detect active review submissions and unrelated unreleased App Store versions that would block creating a new version
  • fail locked target versions before build attachment would fail, and give clearer guidance for PENDING_DEVELOPER_RELEASE
  • add script tests for normal creation, active review blockers, reusable replacement versions, locked targets, and pending-release blockers

Context

The first actual 1.0.18 review submission failed after a successful dry-run with App Store Connect returning a 409 ENTITY_ERROR.RELATIONSHIP.INVALID / "You cannot create a new version of the App in the current state." This patch closes that false-positive dry-run path.

Validation

  • python3 -m unittest Tests/ScriptsTests/test_submit_app_store_review.py (24 tests)
  • scripts/commit-gate.sh (258 Swift tests)
  • git diff --check
  • python3 -m py_compile scripts/submit-app-store-review.py Tests/ScriptsTests/test_submit_app_store_review.py
  • Claude review: no blockers after latest state-model patch
  • Gemini/Antigravity review: no blockers after latest state-model patch

@cbusillo cbusillo merged commit 68fa78c into main Jun 7, 2026
3 checks passed
@cbusillo cbusillo deleted the fix/app-store-review-dry-run-version-state branch June 7, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant