Move ingress provider env wiring behind adapter#1066
Merged
Conversation
This was referenced May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #1065
Refs #1041
Validation
git diff --checkuv run --extra dev ruff check control_plane/workflows/ingress_provider.py control_plane/service.py tests/test_ingress_provider.pyuv run python -m unittest tests.test_ingress_provider tests.test_npmplus_ingress_workflow tests.test_ingress_cli tests.test_service.LaunchplaneServiceTests.test_npmplus_ingress_route_apply_dry_run_returns_plan_without_mutation tests.test_service.LaunchplaneServiceTests.test_npmplus_ingress_route_apply_mutates_when_authorized tests.test_service.LaunchplaneServiceTests.test_ingress_route_apply_uses_provider_adapter tests.test_service.LaunchplaneServiceTests.test_npmplus_ingress_route_apply_fails_before_mutation_when_audit_unavailable tests.test_service.LaunchplaneServiceTests.test_npmplus_ingress_route_apply_requires_idempotency_key tests.test_service.LaunchplaneServiceTests.test_npmplus_ingress_route_apply_rejects_unauthorized_contextuv run python -m unittest tests.test_ingress_provider tests.test_generic_web_deploy