Skip to content

Harden direct Dokploy rollback break-glass#1074

Merged
cbusillo merged 1 commit into
mainfrom
bound-self-deploy-break-glass
May 31, 2026
Merged

Harden direct Dokploy rollback break-glass#1074
cbusillo merged 1 commit into
mainfrom
bound-self-deploy-break-glass

Conversation

@cbusillo
Copy link
Copy Markdown
Owner

Summary

  • fail closed when manual direct Dokploy rollback is dispatched without a rollback image or reason
  • pass the operator reason into the emergency rollback script
  • include the operator reason in reviewable break-glass evidence

Tests

  • git diff --check
  • uv run --extra dev ruff check scripts/deploy/emergency-dokploy-rollback.py tests/test_emergency_dokploy_rollback.py tests/test_product_onboarding.py --diff
  • uv run --extra dev ruff check scripts/deploy/emergency-dokploy-rollback.py tests/test_emergency_dokploy_rollback.py tests/test_product_onboarding.py
  • uv run python -m unittest tests.test_emergency_dokploy_rollback tests.test_product_onboarding
  • docker run --rm -v "$PWD:/repo" -w /repo rhysd/actionlint:1.7.7 -config-file .github/actionlint.yaml .github/workflows/deploy-launchplane.yml

Refs #1049

@cbusillo cbusillo merged commit 6d677c2 into main May 31, 2026
12 checks passed
@cbusillo cbusillo deleted the bound-self-deploy-break-glass branch May 31, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant