Narrow product onboarding apply authority#1076
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
product_onboarding.applyauthority for/v1/product-onboarding/applyLaunchplane Seed Importworkflow instead of broad self-deploy authorityRefs #1049
Validation
uv run python -m unittest tests.test_service.LaunchplaneServiceTests.test_product_onboarding_endpoint_writes_full_launchplane_owned_bundle tests.test_service.LaunchplaneServiceTests.test_product_onboarding_endpoint_rejects_self_deploy_authority tests.test_product_onboardinguv run --extra dev ruff check control_plane/service.py tests/test_service.py tests/test_product_onboarding.pybash -n scripts/deploy/ensure-authz-grants.shgit diff --checkdocker run --rm -v "$PWD:/repo" -w /repo rhysd/actionlint:1.7.7 -config-file .github/actionlint.yaml .github/workflows/deploy-launchplane.yml .github/workflows/launchplane-seed-import.ymlOperator note
This prevents new seed-import product onboarding authority from riding on
launchplane_service_deploy.execute. Any already-persisted broad authz policy rules remain a separate cleanup concern; this route now ignores that broad action for product onboarding apply.