Skip to content

Restrict runtime placeholder retirement scope#1124

Merged
cbusillo merged 1 commit into
mainfrom
fix-runtime-placeholder-retirement-scope
Jun 2, 2026
Merged

Restrict runtime placeholder retirement scope#1124
cbusillo merged 1 commit into
mainfrom
fix-runtime-placeholder-retirement-scope

Conversation

@cbusillo
Copy link
Copy Markdown
Owner

@cbusillo cbusillo commented Jun 2, 2026

Summary

  • require runtime-secret placeholder retirement to have a nonblank context and instance route
  • keep retirement constrained to bindings whose context and instance exactly match the configured secret
  • add a regression test for broad/blank-route retirement leaving unrelated placeholders untouched

Validation

  • uv run python -m unittest tests.test_runtime_environments
  • uv run --extra dev ruff check --fix --diff control_plane/product_config.py tests/test_runtime_environments.py
  • uv run --extra dev ruff check control_plane/product_config.py tests/test_runtime_environments.py
  • uv run --extra dev ruff format --check control_plane/product_config.py tests/test_runtime_environments.py
  • uv run --extra dev mypy control_plane/product_config.py tests/test_runtime_environments.py
  • uv run python -m unittest

@cbusillo cbusillo merged commit 0e94e1a into main Jun 2, 2026
12 checks passed
@cbusillo cbusillo deleted the fix-runtime-placeholder-retirement-scope branch June 2, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant