Preserve deploy idempotency after post-deploy failure#928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
uv run python -m unittest tests.test_service.LaunchplaneServiceTests.test_generic_web_deploy_route_replays_post_deploy_failure_after_deploy_passuv run python -m unittest tests.test_service.LaunchplaneServiceTests.test_generic_web_deploy_route_replays_post_deploy_failure_after_deploy_pass tests.test_service.LaunchplaneServiceTests.test_generic_web_deploy_route_accepts_base_driver_product tests.test_service.LaunchplaneServiceTests.test_generic_web_rollback_route_replays_idempotent_response_shape tests.test_generic_web_deploy tests.test_generic_web_rollbackuv run --extra dev ruff check control_plane/service.py tests/test_service.pyuv run --extra dev ruff format --check control_plane/service.py tests/test_service.pyuv run --extra dev mypy control_plane testsuv run python -m unittest(1622 tests)