Classify VeriReel preview backend failures#947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.invalidpreview URL in accepted VeriReel config-failure responsesVerification
uv run python -m unittest tests.test_verireel_preview_driver tests.test_service.LaunchplaneServiceTests.test_verireel_preview_refresh_driver_executes_for_authorized_workflow tests.test_service.LaunchplaneServiceTests.test_verireel_preview_refresh_driver_writes_failed_generation_record tests.test_service.LaunchplaneServiceTests.test_verireel_preview_refresh_config_error_is_recorded_as_failed_generation tests.test_service.LaunchplaneServiceTests.test_verireel_preview_refresh_transport_error_rejects_without_records tests.test_service.LaunchplaneServiceTests.test_verireel_preview_refresh_payload_validation_still_rejects_bad_sluguv run --extra dev ruff format --check control_plane/service.py control_plane/workflows/verireel_preview_driver.py tests/test_service.py tests/test_verireel_preview_driver.pyuv run --extra dev ruff check control_plane/service.py control_plane/workflows/verireel_preview_driver.py tests/test_service.py tests/test_verireel_preview_driver.pyuv run --extra dev mypy control_plane/service.py control_plane/workflows/verireel_preview_driver.py tests/test_service.py tests/test_verireel_preview_driver.pyFollow-up to auto-review findings on #945.