Skip to content

Use credential helper for source selector auth#48

Merged
shiny-code-bot merged 1 commit into
mainfrom
fix/source-token-credential-helper
May 28, 2026
Merged

Use credential helper for source selector auth#48
shiny-code-bot merged 1 commit into
mainfrom
fix/source-token-credential-helper

Conversation

@shiny-code-bot
Copy link
Copy Markdown
Collaborator

Summary

  • use an environment-backed Git credential helper for private source selector resolution
  • keep source tokens out of process arguments while avoiding runner extraheader issues
  • cover the credential-helper git environment in unit tests

Tests

  • uv run python -m unittest tests.test_runtime.RuntimeCommandTests.test_resolve_source_repository_ref_to_git_sha_uses_credential_helper tests.test_runtime.RuntimeCommandTests.test_resolve_artifact_runtime_source_refs_uses_dedicated_source_token_env tests.test_runtime.RuntimeCommandTests.test_resolve_artifact_runtime_source_refs_supports_ci_source_token_env tests.test_runtime.RuntimeCommandTests.test_resolve_artifact_runtime_source_refs_prefers_runtime_github_token
  • uv run ruff format --check odoo_devkit/local_runtime.py tests/test_runtime.py
  • uv run ruff check odoo_devkit/local_runtime.py tests/test_runtime.py

@shiny-code-bot shiny-code-bot merged commit 0fb635e into main May 28, 2026
4 checks passed
@shiny-code-bot shiny-code-bot deleted the fix/source-token-credential-helper branch May 28, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants