Why can't an absolute path be converted to relative path for a symlink?

[ahufan]

Hi,

It is unclear to me why we can't change absolute path to relative path for symlink, we don't need to call realpath(3). This caused cache miss if the input .c/cpp file is a symlink.

thanks,
Justin

if (is_symlink(argv[i])) {
   // Don't rewrite source file path if it's a symlink since
   // make_relative_path resolves symlinks using realpath(3) and this leads
   // to potentially choosing incorrect relative header files. See the
   // "symlink to source file" test.
   input_file = x_strdup(argv[i]);
} else {
    // Rewrite to relative to increase hit rate.
    input_file = make_relative_path(x_strdup(argv[i]));
}

https://github.com/alibaba/xcache/issues/3

[jrosdahl]

Already answered in #553.