Skip to content

Bugfix - rewrite .d file path from abs to rel#201

Closed
venkrao wants to merge 2 commits into
ccache:3.3-maintfrom
venkrao:patch-1
Closed

Bugfix - rewrite .d file path from abs to rel#201
venkrao wants to merge 2 commits into
ccache:3.3-maintfrom
venkrao:patch-1

Conversation

@venkrao
Copy link
Copy Markdown

@venkrao venkrao commented Oct 25, 2017

If the cache-hit is via preprocessor mode, then, the absolute paths in the .d files are not translated to relative. This is a bugfix for that problem.

If the cache-hit is via preprocessor mode, then, the absolute paths in the .d files are not translated to relative. This is a bugfix for that problem.
@jrosdahl
Copy link
Copy Markdown
Member

I replied to your mail on the ccache list before I saw this pull request.

What do you think about

--- a/ccache.c
+++ b/ccache.c
@@ -1964,11 +1964,6 @@ from_cache(enum fromcache_call_mode mode, bool put_object_in_manifest)
                update_mtime(cached_dwo);
        }
 
-       if (generating_dependencies && mode == FROMCACHE_CPP_MODE
-           && !conf->read_only && !conf->read_only_direct) {
-               put_file_in_cache(output_dep, cached_dep);
-       }
-
        send_cached_stderr();
 
        if (put_object_in_manifest) {

as a fix?

@jrosdahl jrosdahl added the issue: bug Does not work as intended/documented label Jan 5, 2018
@jrosdahl jrosdahl added this to the 3.3.5 milestone Jan 5, 2018
@jrosdahl
Copy link
Copy Markdown
Member

I committed my suggestion in 04c6075.

@jrosdahl jrosdahl closed this Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

issue: bug Does not work as intended/documented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants