-
Notifications
You must be signed in to change notification settings - Fork 1
Create a vignette outlining how to extract comparables from LightGBM #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
=======================================
Coverage 80.32% 80.32%
=======================================
Files 3 3
Lines 122 122
=======================================
Hits 98 98
Misses 24 24 |
|
praise (negging): I love this. suggestion (condescending):
|
jeancochrane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super clear and easy to follow, bravo!
11f0a95 to
de41664
Compare
|
This is looking great! I'd like to propose a few slight refinements before publication. Happy to discuss. The goal is to answer, "What sales did you use to value my property?" The novel contribution is the ability to answer this precise question, and it's important to distinguish "sales used for valuation by the model" from "all comparable properties." CookViewer and SmartFile are way to properties that are merely comparable based on characteristics, regardless of sale status, and it's important to make salient that this is a different method to answer a foundationally different question. To that end... General suggestions about conventions used throughout the vignette:
Specific suggestions
|
|
@ccao-jardine You missed the boat on this PR but these are good points. Moved to issue #4. |
This PR adds a vignette outlining the process of extracting comparable properties from a LightGBM model using a novel leaf node matching technique. It does not include code updates to the package since the code required for comp finding is short enough to simply be inlined anywhere we would actually use it.
Most of the credit for this goes to our former intern Claire Boyd.
Since we don't have PR previews setup yet for our package docs, you'll need to download the following zip file, decompress it, then open the HTML doc to view the knit content: finding-comps.html.zip
The vignette code itself is a mess, but is extremely non-critical, so I'm fine with it.
Closes #1.