Conversation
aij
changed the title
It would be nice if we had a better way of handling "decoders" that can't fail
aij
commented
Jun 27, 2019
| (NonEmptyArray.head group) | ||
| { typ = traverse _.typ group <#> NonEmptyArray.toArray | ||
| >>> Array.sort >>> Array.nub >>> intercalate ", " | ||
| } |
Contributor
Author
There was a problem hiding this comment.
If we didn't need to worry about inconsistent aliases, this could probably be simplified back to something like 4d67ecb#diff-a2d0fa98f8aa6dfd7a52cc9d690ddc2bL37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.