Skip to content

SYS-8273 catch more window cases, add python and python 3 cases#35

Merged
mmaharjan-ccdc merged 3 commits into
mainfrom
SYS-8273-fix-windows-commit
Apr 30, 2026
Merged

SYS-8273 catch more window cases, add python and python 3 cases#35
mmaharjan-ccdc merged 3 commits into
mainfrom
SYS-8273-fix-windows-commit

Conversation

@mmaharjan-ccdc
Copy link
Copy Markdown
Contributor

@mmaharjan-ccdc mmaharjan-ccdc commented Apr 30, 2026

No description provided.

…est with import sys and add error if not found
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the git hook shell wrappers to better detect Windows-like environments and to select an available Python interpreter before delegating to the corresponding *.py hook implementation.

Changes:

  • Expand $OSTYPE matching to include additional Windows/MSYS variants and standardize log messages.
  • Prefer python3 when available, otherwise fall back to python, and fail fast with an error when no runnable Python is found.
  • Switch to array-based invocation ("${PYTHON_EXECUTABLE[@]}") to keep command execution robust.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
main/pre-merge-commit Updates OS detection and Python selection logic for the pre-merge hook wrapper.
main/pre-commit Updates OS detection and Python selection logic for the pre-commit hook wrapper.
main/commit-msg Updates OS detection and Python selection logic for the commit-msg hook wrapper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread main/pre-merge-commit Outdated
Comment thread main/pre-commit Outdated
Comment thread main/commit-msg Outdated
Comment thread main/pre-merge-commit
Comment thread main/pre-commit
Comment thread main/commit-msg
@mmaharjan-ccdc mmaharjan-ccdc changed the title SYS-8273 catch more window cases, add python and python 3 cases and t… SYS-8273 catch more window cases, add python and python 3 cases Apr 30, 2026
@mmaharjan-ccdc mmaharjan-ccdc merged commit 62e2405 into main Apr 30, 2026
6 checks passed
@mmaharjan-ccdc mmaharjan-ccdc deleted the SYS-8273-fix-windows-commit branch April 30, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants