refactor: reduce complexity, remove dead code, add oxlint plugins by ccombe · Pull Request #47 · ccombe/emom-timer

ccombe · 2026-05-10T02:54:45Z

Summary

This PR cleans up the codebase with multiple improvements:

Complexity Reduction

Extract tone scheduling helper in audio.ts, simplify playEndSound
Group DOM queries in ui.ts, standardize on textContent, fix TS strict initialization
Extract auth/token helpers in google-fit.ts, simplify uploadSession
normalizeConfig CRAP score dropped from 110 → clean (extracted pickMode, pickNumber, pickBool)
determineIntervalCount CRAP score dropped from 42 → clean

Dead Code Removal

TimerEngine.toggle() — only used in tests
StorageService.getHistory() — never called
StorageService.close() — never called

Linting Improvements

Add oxlint JS plugins: eslint-plugin-testing-library, eslint-plugin-playwright, eslint-plugin-sonarjs
Enable 8 additional sonarjs rules
Clean all 14 console.log/warn/error debug statements
155 rules active (was 95), 0 warnings, 0 errors

Fallow Integration

Add regression baseline tracking
Save health snapshot for trend monitoring
Configure fallow-mcp in opencode.json for agent tooling

CI Updates

Add code-quality job with lint + regression check
Trigger on push to master as well as PRs

Verification

✅ All 55 tests pass
✅ TypeScript compiles clean (tsc --noEmit)
✅ Oxlint: 0 warnings, 0 errors (155 rules)
✅ Fallow: maintainability 88.7 (good), 0 dead code, 0 duplication

…ean consoles - Extract tone scheduling helper in audio.ts, simplify playEndSound - Group DOM queries in ui.ts, standardize textContent, fix TS strict init - Extract auth/token helpers in google-fit.ts, simplify uploadSession - Remove dead code: TimerEngine.toggle, StorageService.getHistory/close - Reduce complexity: normalizeConfig (CRAP 110→clean), determineIntervalCount - Add oxlint JS plugins: eslint-plugin-testing-library, playwright, sonarjs - Clean all 14 console.log/warn/error debug statements - Enable 8 additional sonarjs rules (no-gratuitous-expressions, etc.) - Add fallow regression baseline + health snapshot tracking - Configure fallow-mcp in opencode.json for agent tooling - Update CI with code-quality job + lint + regression check - Fix tests for removed console calls and dead code - All 55 tests pass, 155 rules active, 0 warnings, 0 errors

sonarqubecloud · 2026-05-10T03:05:40Z

Quality Gate passed

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codescene-delta-analysis

No quality gates enabled for this code.

See analysis details in CodeScene

Quality Gate Profile: Custom Configuration
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.