Add sendResult method #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoreilly
requested changes
Nov 4, 2022
Owner
ccoreilly
left a comment
ccoreilly
left a comment
There was a problem hiding this comment.
Please change sendResults to retrieveFinalResult where applicable
lib/src/model.ts
Outdated
| ); | ||
| } | ||
|
|
||
| public sendResults(): void { |
Owner
There was a problem hiding this comment.
I would prefer to call the public method retrieveFinalResult. Singular because only one result will be sent after calling the method. retrieve because, although you're telling the worker to send the final result, from the client perspective you want to get the result (but as it is an event triggering action I think get would be confusing).
Other than naming the rest looks awesome, thanks for contributing @Clement-mim !
Contributor
Author
|
It should be better now. |
Owner
|
Thank you for your contribution! |
ccoreilly
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #54