feat: retry transient remote peer errors#5
Merged
Conversation
- Wraps the Get/Set/Remove peer calls in a shared callRemoteIfRemoteOwner helper that retries ErrRemoteCall (which includes httpGetter being closed) responses with exponential backoff (from 1ms to 20ms, up to 250ms total) and records peer errors on the active span. When the retry budget is exhausted, the local load or other operations are to kick in. Also introduces a NoopLogger default so callers no longer need nil checks, and adds TestHttpGetterClosed covering the close/remove race through a fake PeerPicker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps the Get/Set/Remove peer calls in a shared callRemoteIfRemoteOwner helper that retries ErrRemoteCall (which includes httpGetter being closed) responses with exponential backoff (from 1ms to 20ms, up to 250ms total) and records peer errors on the active span. When the retry budget is exhausted, the local load or other operations are to kick in.
Also introduces a NoopLogger default so callers no longer need nil checks, and adds TestHttpGetterClosed covering the close/remove race through a fake PeerPicker.