fix(chores): restore daily multi edit flow (#37)#40
Merged
Conversation
What changed: - route existing DAILY_MULTI chore edits back through the helper step - fix DAILY_MULTI skip_due_date to advance from the current slot on repeated skips - add regression coverage for edit-helper reopening and repeated skip advancement Why: - issue 37 required the DAILY_MULTI edit helper to reopen consistently - skip_due_date breakage was found during issue 37 testing and remediated in the same fix set
ccpk1
added a commit
that referenced
this pull request
Mar 15, 2026
* chore(ci): retarget integration workflows to dev What changed:\n- Run translation sync from dev\n- Enable PR validation for dev-targeted PRs\n- Keep main as stable release branch\n\nWhy:\n- Establish dev as the pre-staging branch so fixes flow through dev before main\n * fix(chores): enforce due-date recurrence contract for #22 What changed: - Require due dates for recurring chore schedules outside none/daily - Exclude all no-due-date chores from calendar generation - Limit no-due-date daily chores to weekday-gated dashboard/statistics visibility - Reject service attempts to clear due dates from weekly/monthly/custom recurring chores - Update shared scenarios and regression tests to match the supported scheduling contract - Document the behavior change and the recommended alternative of using a due date with overdue handling set to never overdue - Raise the translation sensor warning ceiling from 9 KB to 10 KB - Wiki updated with guidance Why: - Fixes issue #22, where applicable-day split chores behaved like they were due every day and produced inconsistent calendar behavior - Clarifies a functional change for some existing configurations: recurring chores without due dates are no longer a supported path outside none/daily - Keeps recurrence, calendar output, dashboard grouping, and service/edit validation on one consistent scheduling rule - Preserves the recommended way to repeat a chore without lateness by using a due date and selecting never overdue * fix(dashboard): support legacy frontend panel API What changed: Added a compatibility wrapper for dashboard panel registration Used the wrapper in both dashboard create and update paths Added tests covering both old and new Home Assistant frontend API signatures Why: Home Assistant changed the frontend panel registration API in 2026.3 Older versions reject show_in_sidebar, which caused dashboard generation to fail This keeps newer behavior intact while allowing older supported installs to continue working * fix(ci): make translation sync dev-aware * chore(l10n): sync translations from Crowdin (#27) * chore(l10n): sync translations from Crowdin * chore(l10n): sync translations from Crowdin * chore(ci): trigger translation PR checks --------- Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: ccpk1 <shillingcl@gmail.com> * chore(release): prepare 1.0.1 * fix(notifications): preserve reward notif ids (#34) (#38) What changed: - keep notif_id in reward claim notification actions - preserve notif_id on reward reminder notification actions - add regression coverage for claim and reminder payloads Why: - reward approval actions from notifications were losing notif_id and failing to parse - follow-up reward reminders had the same malformed action risk Refs: #34 * fix(chores): restore daily multi edit flow (#37) (#40) What changed: - route existing DAILY_MULTI chore edits back through the helper step - fix DAILY_MULTI skip_due_date to advance from the current slot on repeated skips - add regression coverage for edit-helper reopening and repeated skip advancement Why: - issue 37 required the DAILY_MULTI edit helper to reopen consistently - skip_due_date breakage was found during issue 37 testing and remediated in the same fix set * fix(users): clean stale helpers and add-user form (#35) (#42) * fix(chores): restore daily multi edit flow (#37) What changed: - route existing DAILY_MULTI chore edits back through the helper step - fix DAILY_MULTI skip_due_date to advance from the current slot on repeated skips - add regression coverage for edit-helper reopening and repeated skip advancement Why: - issue 37 required the DAILY_MULTI edit helper to reopen consistently - skip_due_date breakage was found during issue 37 testing and remediated in the same fix set * fix(users): clean stale helpers and add-user form What changed: - add startup cleanup for orphaned assignee calendar and datetime helpers - await add-user schema construction in the options flow - add regression coverage for both paths Why: - fixes #35 by removing stale deleted-user calendar artifacts - fixes an untracked add-user schema serialization crash in options flow * fix(chores): clear stale due dates on reset (#28) (#43) What changed:\n- stop boundary resets from rescheduling non-recurring chores\n- clear stale due dates after fresh-cycle resets for frequency none chores\n- add regressions for issue #28 and midnight no-due-date resets\n\nWhy:\n- stale due dates could survive resets and create false overdue cycles * fix(dashboard): tolerate missing ui resets (#31) (#44) * fix(calendar): align rendering and descriptions (#45) (#46) * fix(calendar): use schedule source of truth (#45) * fix(calendar): localize event descriptions (#45) * chore(release): prepare 1.0.2 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skip_due_daterepeated advancement after finding the regression during issue [ISSUE] Daily multi does not spawn helper step #37 testingValidation
./utils/quick_lint.sh --fixpytest tests/test_workflow_chores.py tests/test_chore_crud_services.py tests/test_chore_scheduling.py tests/test_chore_state_matrix.py tests/test_chore_services.py tests/test_shared_chore_features.py tests/test_chore_manager.py tests/test_chore_engine.py tests/test_chore_missed_tracking.py tests/test_daily_multi_approval_reset.py tests/test_options_flow_daily_multi.py tests/test_due_date_services_enhanced_frequencies.py -v --tb=lineCloses #37