feat(analysis): add QueryHash cache layer with IAnalysisCache#109
Merged
cct08311github merged 2 commits intodotnet8from Mar 9, 2026
Merged
feat(analysis): add QueryHash cache layer with IAnalysisCache#109cct08311github merged 2 commits intodotnet8from
cct08311github merged 2 commits intodotnet8from
Conversation
Prepare for parallel worktree-based development workflow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…97) Add IAnalysisCache interface + MemoryAnalysisCache (IMemoryCache-backed, 5 min default TTL, CancellationToken-based InvalidateAll) and NullAnalysisCache no-op implementation. Integrate into AnalysisQueryEngine (cache lookup before query, store after) and _AnalysisController (DI injection). Register in FrameworkServiceExtension. 7 new MSTest tests covering both implementations and engine integration. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
cct08311github
pushed a commit
that referenced
this pull request
Mar 9, 2026
…#98) Add DateTruncator static class that builds Expression Trees using DateTime.Year/.Month/.Day CLR properties for cross-DB safe date truncation in GroupBy operations. Supports Year, Quarter, Month, Day hierarchies with integer key encoding and human-readable formatting. Also fix pre-existing AnalysisQueryEngine duplicate constructor conflict (from merged #108 + #109) and remove dead ExecuteGroupBy/BuildGroupKey methods already extracted to InProcessGroupByStrategy. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3 tasks
cct08311github
pushed a commit
that referenced
this pull request
Mar 9, 2026
#111) PR #108 (GroupByStrategyResolver) and #109 (IAnalysisCache) each added a parameterless constructor to AnalysisQueryEngine. GitHub auto-merge didn't detect the semantic conflict, causing CS0111 on dotnet8. - Merge both constructor sets into unified ctor accepting both resolver + cache - Remove dead ExecuteGroupBy/BuildGroupKey methods (already in InProcessGroupByStrategy) - Update _AnalysisController and cache tests to use new ctor signature Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IAnalysisCacheinterface (TryGet/Set/Invalidate/InvalidateAll)MemoryAnalysisCachewrappingIMemoryCache(5-min default TTL,CancellationTokenSource-basedInvalidateAll)NullAnalysisCacheno-op implementation for disabled cachingAnalysisQueryEngine— hash computed before query for cache lookup, results stored afterFrameworkServiceExtension.AddWtmContext()registersAddMemoryCache()+IAnalysisCache_AnalysisControlleracceptsIAnalysisCache?via constructor injectionCloses #97
Test plan
AnalysisQueryEngine()still works🤖 Generated with Claude Code