fix(demo): update BatchSaveData signatures to match new #607 API#661
Merged
cct08311github merged 4 commits intodotnet8from Mar 19, 2026
Merged
fix(demo): update BatchSaveData signatures to match new #607 API#661cct08311github merged 4 commits intodotnet8from
cct08311github merged 4 commits intodotnet8from
Conversation
…ange IProgress<ImportProgress>? parameter was added as optional default in BaseImportVM.BatchSaveData. Five demo FrameworkUserImportVM overrides lacked the matching signature, causing CS0115 build errors. Fixes CI build failures on dotnet8 and PR #655. https://claude.ai/code/session_017r2EfWhoDdvECdoncQg6xM
The BlazorDemo.Client (Microsoft.NET.Sdk.BlazorWebAssembly) requires the
wasm-tools workload for the browser-wasm RID. GitHub Actions runners now
ship with .NET 10 preinstalled; without a global.json the newer SDK can
be selected, causing NETSDK1082 ("no runtime pack for browser-wasm").
Changes:
- Add `dotnet workload install wasm-tools` step before dotnet restore
- Add global.json to pin SDK to 8.0.x (latestFeature rollForward)
Fixes CI build-and-test failures on dotnet8 and PR #655.
https://claude.ai/code/session_017r2EfWhoDdvECdoncQg6xM
DOTNET_ROOT points to /usr/share/dotnet (system location), so workload packs must be installed there (with sudo) to be found during the build step. https://claude.ai/code/session_017r2EfWhoDdvECdoncQg6xM
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BaseImportVM.BatchSaveDatagained an optionalIProgress<ImportProgress>?parameter (PR feat: implement all open issues (#539 #540 #565 #566 #607 #615 #619 #620) + security fix #659 / issue enhancement(import): progress reporting for large Excel imports (SSE/SignalR) #607)FrameworkUserImportVM.csin BlazorDemo, Demo, ReactDemo, Vue3Demo, VueDemopublic override bool BatchSaveData(System.IProgress<WalkingTec.Mvvm.Core.ImportProgress>? progress = null)matching the base class signatureTest plan
dotnet build WalkingTec.Mvvm.sln -c Releasepasses with 0 errorsdotnet test WalkingTec.Mvvm.sln -c Releasepassesbuild-and-testturns green on dotnet8 and PR feat(analysis): sort, pagination, sticky header for query result table (#539) #655https://claude.ai/code/session_017r2EfWhoDdvECdoncQg6xM