refactor(core): remove last #nullable disable in Core project#703
Merged
cct08311github merged 1 commit intodotnet10from Mar 20, 2026
Merged
refactor(core): remove last #nullable disable in Core project#703cct08311github merged 1 commit intodotnet10from
cct08311github merged 1 commit intodotnet10from
Conversation
TemplateErrorListVM.GetSearchQuery() — EntityList is guaranteed non-null by constructor initialization. Use null-forgiving (!) instead of #nullable disable block. Core project now has zero #nullable disable directives. Closes #698 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the final
#nullable disabledirective inWalkingTec.Mvvm.Core.TemplateErrorListVM.GetSearchQuery()used#nullable disableto suppress a warning onEntityList.AsQueryable(). Since the constructor guaranteesEntityList = new List<ErrorMessage>(), a null-forgiving!is sufficient.Result: Core project now has zero
#nullable disabledirectives.Test plan
Closes #698
🤖 Generated with Claude Code