Expose error codes#60
Merged
balthazar merged 3 commits intoccxt:masterfrom Mar 6, 2018
bennycode:patch-3
Merged
Conversation
Collaborator
|
Perfect! I'm wondering if it would be interesting to expose some error types tight to these codes or would that not be helpful at all? |
Contributor
Author
|
That's a good idea! We can create enums for the error codes, so that checks can be done like this: t.is(e.code, BinanceError.ILLEGAL_CHARS)We can use the same identifiers as listed in the Error codes for Binance document, which are |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves /issues/58 - I am adding the
codefrom the error payload to the error object, so that it can be checked.Test code: