Conversation
albertshau
approved these changes
Oct 10, 2023
Contributor
albertshau
left a comment
albertshau
left a comment
There was a problem hiding this comment.
lgtm, though I guess checkstyle doesn't want it initialized
masoud-io
changed the title
…it is initialized
masoud-io
force-pushed
the
bugfixes/cdap-20797
branch
from
c30cd76 to
4c14821
Compare
Contributor
Author
Thanks. Move initialization to 0 into constructor to fix the checkstyle. |
masoud-io
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: without this change, when DefaultSystemProvisionerContext gets initialized, reloadProperties call is skipped. This causes pipelines to fail because properties (specifically RuntimeJobManager ) are not set initially. Lack of runtime.job.manager in properties causes cdap to try to use ssh, which obviously results in failure.