Conversation
dli357
approved these changes
Dec 26, 2023
Contributor
dli357
left a comment
dli357
left a comment
There was a problem hiding this comment.
nit: Please resolve all checkstyle warnings before merging, thank you!
arjan-bal
force-pushed
the
CDAP-20928-disable-ssl-cert-validation
branch
from
39a3d33 to
4b9d10a
Compare
…combine https configuration for internal router with existing config
arjan-bal
force-pushed
the
CDAP-20928-disable-ssl-cert-validation
branch
from
4b9d10a to
a590565
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CDAP-20928
Internal services may be using ssl certs signed by a private certificate authority. As a result server ssl cert verification will fail unless the certs are added to the trust store of all the clients.
This PR also removes the cdap-site configuration for controlling whether the internal router server uses https. Instead it relies on the pre-existing
ssl.internal.enabledconfiguration to enable https.