[CDAP-20943] Use a separate consumer id for MetadataConsumerSubscriberService#15530
Merged
itsankit-google merged 1 commit intodevelopfrom Jan 23, 2024
Merged
[CDAP-20943] Use a separate consumer id for MetadataConsumerSubscriberService#15530itsankit-google merged 1 commit intodevelopfrom
itsankit-google merged 1 commit intodevelopfrom
Conversation
tivv
reviewed
Jan 23, 2024
Contributor
tivv
left a comment
There was a problem hiding this comment.
Note that we would need to see what does this change mean for upgrade cases. I am not sure if "new" consumer will read all messages for last 7 days or will start fresh (and potentially skip anything unprocessed). If latter, it may miss some messages during upgrade, should not be a bit issue as it's for lineage and anyway previous code misses messages.
9bd2b1b to
e71b305
Compare
tivv
approved these changes
Jan 23, 2024
This was referenced Jan 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: CDAP-20943
Tested: