Skip to content

[CDAP-20943] Use a separate consumer id for MetadataConsumerSubscriberService#15530

Merged
itsankit-google merged 1 commit intodevelopfrom
CDAP-20943
Jan 23, 2024
Merged

[CDAP-20943] Use a separate consumer id for MetadataConsumerSubscriberService#15530
itsankit-google merged 1 commit intodevelopfrom
CDAP-20943

Conversation

@itsankit-google
Copy link
Copy Markdown
Member

@itsankit-google itsankit-google commented Jan 23, 2024

JIRA: CDAP-20943

Tested:

cdap=> select namespace,application,version,program_type,program,run from workflows where run in ('10a248d2-b9ee-11ee-b5d4-e6adf015ef44', '0cbdef44-b9d9-11ee-a8a2-6e00dd568637');
 namespace |     application      |               version                | program_type |       program        |                 run                  
-----------+----------------------+--------------------------------------+--------------+----------------------+--------------------------------------
 default   | DataFusionQuickstart | fe668473-b9d8-11ee-9046-6e00dd568637 | WORKFLOW     | DataPipelineWorkflow | 0cbdef44-b9d9-11ee-a8a2-6e00dd568637
 default   | DataFusionQuickstart | fe668473-b9d8-11ee-9046-6e00dd568637 | WORKFLOW     | DataPipelineWorkflow | 10a248d2-b9ee-11ee-b5d4-e6adf015ef44
(2 rows)

@itsankit-google itsankit-google added the build Triggers github actions build label Jan 23, 2024
@itsankit-google itsankit-google requested a review from tivv January 23, 2024 13:09
Copy link
Copy Markdown
Contributor

@tivv tivv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we would need to see what does this change mean for upgrade cases. I am not sure if "new" consumer will read all messages for last 7 days or will start fresh (and potentially skip anything unprocessed). If latter, it may miss some messages during upgrade, should not be a bit issue as it's for lineage and anyway previous code misses messages.

Comment thread cdap-common/src/main/java/io/cdap/cdap/common/conf/Constants.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Triggers github actions build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants