[CDAP-21223] Fix Cloud Spanner lock contention issues related to count() query #16074
+212
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidhdirenge
changed the title
cdap-storage-spi/src/main/java/io/cdap/cdap/spi/data/StructuredTable.java
Show resolved
Hide resolved
vsethi09
reviewed
Dec 26, 2025
cdap-storage-spi/src/main/java/io/cdap/cdap/spi/data/table/options/StaleReadOption.java
Outdated
Show resolved
Hide resolved
vsethi09
reviewed
Dec 26, 2025
cdap-storage-ext-spanner/src/main/java/io/cdap/cdap/storage/spanner/SpannerStructuredTable.java
Show resolved
Hide resolved
vsethi09
reviewed
Dec 26, 2025
cdap-storage-spi/src/main/java/io/cdap/cdap/spi/data/StructuredTable.java
Outdated
Show resolved
Hide resolved
sidhdirenge
force-pushed
the
sidhdirenge-spanner-lock-1
branch
from
f4aa558 to
7aa8a6b
Compare
vsethi09
approved these changes
Dec 26, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Cloud Spanner lock contention issues encountered in 6.11 instances. The contention was primarily driven by high-frequency
SELECT COUNT(*)queries on therun_recordstable used for flow control. These read queries acquired locks to the table as they were executed as part ofReadWriteTransaction(reference).Changes:
QueryOptioninterface & one of its implementation (StaleReadsOption)StructuredTable.count()method that accepts these QueryOptions.Testing: