Merged
Conversation
Extract _build_index_arrays and _klu_deduplicate as module-level helpers, eliminating ~25 lines of copy-pasted index-building and KLU coalescence logic from DenseSolver, KLUSolver, KLUSplitSolver, KlursSplitSolver, and SparseSolver. Rename from_circuit -> from_component_groups across all solver classes and call sites to reflect the actual input type and leave room for future parsers from other formats. Also fix wrong return type hints on KLUSplitSolver and KlursSplitSolver, and add the missing * keyword-only separator in KlursSplitSolver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from_circuitmethods to reduce duplication of code