[#2] Update documentation Employee #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacky-htg
requested changes
Dec 1, 2020
Contributor
jacky-htg
left a comment
jacky-htg
left a comment
There was a problem hiding this comment.
- Add endpoint for read employee
- Please finalise the complete documentation of one endpoint first, ex: endpoint of POST / employees.
) * [#3] Update Regions Documentation and add a figure of regions table * [#3] Update Region Documentation based on review * [#3] Update Region Documentation based on 2nd review * [#3] add region code must be unique and remove the last line that does not need comma * [#3] Update region-layer * [#3] Rename regions.png to region-layer.png * [#3] Remove company_code and kunci from regions table
ferrystiawan
requested review from
AhmadGozali19,
Jonsen-92,
dzakitajudin,
fakhri007,
jacky-htg,
juniartha-im,
lukman134 and
msyuniarto
msyuniarto
requested changes
Dec 7, 2020
doc/employees.md
Outdated
Comment on lines
36
to
37
| "stall_code": "Heavy Repair", | ||
Contributor
There was a problem hiding this comment.
baris terakhir gak butuh tanda koma, hapus baris kosong
msyuniarto
approved these changes
Dec 7, 2020
doc/employees.md
Outdated
| "employee_nama": "ferry", | ||
| "stall_code": "Heavy Repair", | ||
| "stall_code": "Heavy Repair" | ||
Contributor
There was a problem hiding this comment.
ini dihapus aja fer baris kosongnya, biar rapi
Contributor
Author
There was a problem hiding this comment.
baik mas @msyuniarto sudah diganti mohon di review kembali
jacky-htg
requested changes
Dec 7, 2020
doc/employees.md
Outdated
| @@ -1 +1,605 @@ | |||
| # Employees Module | |||
| Module | Description | |||
Contributor
There was a problem hiding this comment.
wrong table format.
| Module | Method | Description |
|---|
jacky-htg
approved these changes
Dec 8, 2020
fakhri007
approved these changes
Dec 8, 2020
fakhri007
pushed a commit
that referenced
this pull request
Dec 10, 2020
* [#2] Update documentation Employee * [#2] Update Employee - Add Database Employee * [#3] Update Regions Documentation and add a figure of regions table (#16) * [#3] Update Regions Documentation and add a figure of regions table * [#3] Update Region Documentation based on review * [#3] Update Region Documentation based on 2nd review * [#3] add region code must be unique and remove the last line that does not need comma * [#3] Update region-layer * [#3] Rename regions.png to region-layer.png * [#3] Remove company_code and kunci from regions table * [#2] Update documentation Employee * [#2] Update Employee - Add Database Employee * [#2] Revise documentation Employee * [#2] Update email Documentation * [#2] Update email Documentation * [#2] Completing documentation Co-authored-by: Muhammad Sofi Yuniarto <58578584+msyuniarto@users.noreply.github.com>
fakhri007
added a commit
that referenced
this pull request
Dec 11, 2020
* add validation logic on login * [#9] add documentation * [#9] add documentation forgot password * [#9] revise add documentation forgot password * [#9] revise add document forgot password(2) * [#9] add forgot password layer image * [#9] revise forgot password layer and add documentation change password * [#9] add documentation reset password * add validation logic on login * [#9] revise documentation change password and reset password * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * [#9] update change password and reset password documentation * add validation logic on login * add validation logic on login * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * add validation logic on login * [#9] re-update change password, forgot password, and reset password * [#9] resolve conflict * [#9] resolve conflict * [#9] revise documentation change password * [#3] Update Regions Documentation and add a figure of regions table (#16) * [#3] Update Regions Documentation and add a figure of regions table * [#3] Update Region Documentation based on review * [#3] Update Region Documentation based on 2nd review * [#3] add region code must be unique and remove the last line that does not need comma * [#3] Update region-layer * [#3] Rename regions.png to region-layer.png * [#3] Remove company_code and kunci from regions table * [#9] resolve conflict * [#9] resolve conflict * add validation logic on login * [#9] resolve conflict * [#9] update doc * [#9] update doc 2 * [#2] Update documentation Employee (#15) * [#2] Update documentation Employee * [#2] Update Employee - Add Database Employee * [#3] Update Regions Documentation and add a figure of regions table (#16) * [#3] Update Regions Documentation and add a figure of regions table * [#3] Update Region Documentation based on review * [#3] Update Region Documentation based on 2nd review * [#3] add region code must be unique and remove the last line that does not need comma * [#3] Update region-layer * [#3] Rename regions.png to region-layer.png * [#3] Remove company_code and kunci from regions table * [#2] Update documentation Employee * [#2] Update Employee - Add Database Employee * [#2] Revise documentation Employee * [#2] Update email Documentation * [#2] Update email Documentation * [#2] Completing documentation Co-authored-by: Muhammad Sofi Yuniarto <58578584+msyuniarto@users.noreply.github.com> * [#9] add documentation * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * [#9] resolve conflict * [#9] bring back acl-layer Co-authored-by: Rijal Asepnugroho <rasepnugroho@waresix.com> Co-authored-by: Muhammad Sofi Yuniarto <58578584+msyuniarto@users.noreply.github.com> Co-authored-by: ferrystiawan <56244036+ferrystiawan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.