fix: pin goimports to v0.42.0 to support Go 1.24#127
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
=======================================
Coverage 85.12% 85.12%
=======================================
Files 149 149
Lines 13095 13095
=======================================
Hits 11147 11147
Misses 1631 1631
Partials 317 317 🚀 New features to boost your workflow:
|
golang.org/x/tools v0.43.0 requires Go >= 1.25; pinning to v0.42.0 keeps the toolchain compatible with the go 1.24 requirement in go.mod. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
2cae214 to
31cd481
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
golang.org/x/tools@latestresolved to v0.43.0 which requires Go >= 1.25go 1.24.0ingo.mod, so CI fails withGOTOOLCHAIN=localgoimportstov0.42.0, the last release compatible with Go 1.24Test plan
make fmtstep passes without thego >= 1.25.0error🤖 Generated with Claude Code