Fix source from the context links#119
Closed
randomnoise wants to merge 1 commit intocdevents:mainfrom
randomnoise:fix-source-context-link
Closed
Fix source from the context links#119randomnoise wants to merge 1 commit intocdevents:mainfrom randomnoise:fix-source-context-link
randomnoise wants to merge 1 commit intocdevents:mainfrom
randomnoise:fix-source-context-link
Conversation
It seems there was change where spec.md located in directory stucture and also there are 2 sources, one for the context, another for the subject in spec.md. So, current links give 404 error. This remedies the problem.
4 tasks
afrittoli
reviewed
Mar 13, 2023
Member
afrittoli
left a comment
afrittoli
left a comment
There was a problem hiding this comment.
Thanks for this, we missed these links when moving docs around!
I think the links should not start with a forward slash.
| |-------|------|-------------|----------| | ||
| | id | `String` | Uniquely identifies the subject within the source. | `1234`, `maven123`, `builds/taskrun123` | | ||
| | source | `URI-Reference` | [source](../spec.md#source) from the context | `staging/tekton`, `tekton-dev-123`| | ||
| | source | `URI-Reference` | [source](/spec.md#source-context) from the context | `staging/tekton`, `tekton-dev-123`| |
Member
|
Thanks @randomnoise for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
It seems there was change where spec.md located in directory stucture and also there are 2 sources; one for the context, another for the subject in spec.md. So, current links give 404 errors.
This remedies the problem.
Submitter Checklist
As the author of this PR, please check off the items in this checklist: