Skip to content

Conversation

@SFJohnson24
Copy link
Collaborator

@SFJohnson24 SFJohnson24 commented Dec 10, 2025

This PR updates the previous ticket--removes ct_packages argument and now dynamically grabs the package, builds a key, and looks up the CT.

To test: cg0288 and test data from sharepoint
Rule_underscores.json

@SFJohnson24 SFJohnson24 marked this pull request as ready for review December 10, 2025 20:52
@SFJohnson24 SFJohnson24 self-assigned this Dec 10, 2025
Copy link
Collaborator

@RamilCDISC RamilCDISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR updates the engine to automatically get the ct_packages. The validation was done by:

  1. Reviewing the PR for any unwanted code or comments.
  2. Reviewing the PR logic in accordance of the AC.
  3. Ensuring all unit and regression testing pass.
  4. Ensuring all related testing is updated as required.
  5. Ensuring all documentation is updated and has removed any mentions of ct_packages.
  6. Running manual validations using positive datasets.
  7. Running manual validations using negative datasets.
  8. Ensuring edge cases of missing, empty and nans.

@RamilCDISC RamilCDISC merged commit e29165d into main Dec 15, 2025
11 checks passed
@RamilCDISC RamilCDISC deleted the codelist_att branch December 15, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants