-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Update (and streamline) the default runtime to be DOTNET_8 #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update (and streamline) the default runtime to be DOTNET_8 #260
Conversation
vlesierse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With .NET 8 as default and the out of support of .NET 6 in November, this fix makes sense. It is a breaking change though, so we should mark it as features or include this in the other PR #259 with a minor version bump.
Now that #259 is marked as a In terms of versioning - the current version is Many options to choose from - let me know what you think. |
|
@lachriz-aws we can leave both PR separate. For versioning, currently this library is marked as experimental by the CDK team. We can take this to them on what is needed to bring it to a stable 1.0 release. Meanwhile following semantic versioning 0.1.0 would be a good next version for this feature. |
…t runtime (will be replaced by a dotnet6 variant).
…023 (PROVIDED_AL2023).
…g to take a dependency on libicu.
|
Thanks for the above feedback @vlesierse. The PR now contains the following changes:
Also, a new integ test project Finally, I should mention that the <ItemGroup Condition="'$(RuntimeIdentifier)' == 'linux-arm64'">
<RuntimeHostConfigurationOption Include="System.Globalization.AppLocalIcu" Value="68.2.0.9" />
<PackageReference Include="Microsoft.ICU.ICU4C.Runtime" Version="68.2.0.9" />
</ItemGroup>Since globalization is not really core to the tests, I have simply replaced that inclusion with the below: <!-- Disable globalization support to avoid having to take a dependency on libicu -->
<InvariantGlobalization>true</InvariantGlobalization> |
vlesierse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The default runtime was set to
DOTNET_6while the docs saidPROVIDED_AL2. This PR streamlines this, and changes the default runtime to beDOTNET_8.