feat: Add support for custom service environment blueprints#8
Merged
gyalai-aws merged 3 commits intocdklabs:mainfrom Mar 11, 2025
Merged
feat: Add support for custom service environment blueprints#8gyalai-aws merged 3 commits intocdklabs:mainfrom
gyalai-aws merged 3 commits intocdklabs:mainfrom
Conversation
…is is required for custom aws service environments) - Removed environmentRoleArn from environment-profile.ts since environment profile does not support this
gyalai-aws
requested changes
Mar 8, 2025
Contributor
gyalai-aws
left a comment
There was a problem hiding this comment.
Thank you for your improvements. All looks good. Now just the build needs to be fixed.
Can you run the followings the get the buiild passed, please?
npm run upgrade
npm run build
added 2 commits
March 10, 2025 08:39
…is is required for custom aws service environments) - Removed environmentRoleArn from environment-profile.ts since environment profile does not support this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Justification
https://docs.aws.amazon.com/datazone/latest/userguide/working-with-custom-blueprint.html
Custom Service Blueprints are unique in that they do not require environment profiles. They require the blueprint Id, and the environment account id, environment account region. They are a synchronous for of environment creation. Currently, there is a customer trying to use this package and cannot pass in the blueprint identifier, since custom service blueprints dont have an environment profile the environment creation in cloud formation fails. Below is a comparison between a working CFN template and one synthesized from this package before the above change
Synthesized with this library (Json)
Expected Template to Work with CFN (Yaml -My Personal Preference)
Testing
Author (Vincent Pietropaolo (vapp)) - Original developer of custom service blueprints for datazone (Both backend and CFN IAC code)