feat(docdb): add monitoring for Document DB #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
ghost
suggested changes
Jun 21, 2022
| } from "./DocumentDbMetricFactory"; | ||
|
|
||
| export interface DocumentDbMonitoringOptions extends BaseMonitoringProps { | ||
| readonly addCpuUsageAlarm?: Record<string, UsageThreshold>; |
There was a problem hiding this comment.
Were you planning on introducing more alarms later, or upon request?
Contributor
Author
There was a problem hiding this comment.
I will probably introduce more, just need to check with the client.
Co-authored-by: Eugene Cheung <81188333+echeung-amzn@users.noreply.github.com>
Contributor
Author
Happy to, since there is this L2 construct. However, I am not sure if there is a way to distinguish different cluster types, e.g. DocDB cluster from RDS cluster. Will check what the exact type of differentiator is. |
Signed-off-by: github-actions <github-actions@github.com>
ayush987goyal
suggested changes
Jun 22, 2022
ayush987goyal
added
the
do-not-merge
ayush987goyal
approved these changes
Jun 24, 2022
Contributor
ayush987goyal
left a comment
ayush987goyal
left a comment
There was a problem hiding this comment.
Thanks a lot for making these changes!
Contributor
Author
|
Hey folks, thanks for review. Did I miss any change requested? Please let me know :). |
ghost
approved these changes
Jun 27, 2022
ghost
removed
the
do-not-merge
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #167
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license