feat: support multiple cdk types on packages #912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chriscbr
approved these changes
Feb 14, 2022
| * Back-end will introduce a new metadata.constructFrameworks property to replace metadata.constructFramework | ||
| * @deprecated Use constructFrameworks instead | ||
| */ | ||
| constructFramework?: Partial<ConstructFramework>; |
Contributor
Author
There was a problem hiding this comment.
Just so that I could re-use the type for the new implementation. The old signature allowed cdkType and majorVersion to be undefined, whereas moving forward we should only define a constructFramework object if there is a cdkType associated
mergify bot
pushed a commit
to cdklabs/construct-hub
that referenced
this pull request
Mar 15, 2022
Fixes #717 The changes required to support this in the front-end have already been added in cdklabs/construct-hub-webapp#912. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #900
Implements backward compatible support for multi cdk type constructs in construct hub. When sorting by CDK type, "Multi-CDK" constructs will show in the results for any of their matching CDK types. Additionally, they will have a "Multi-CDK" badge, which shows a tooltip when hovered.
The tooltip (now) has an arrow and is placed to the left