Remove local overrides, fix icons, gems#137
Merged
Merged
Conversation
Fix icon display in Odds 'n ends section
Gem information comes back in a table so we need to unpack the data
Update OutfitterInventory.lua
Update Outfitter.lua
Assigning an outfit texture to an icon now handled in two ways.
Update Outfitter.lua
Removed temporary local override of functions that moved to C_Container. Applied C_Container to appropriate calls as necessary.
Removed temporary local override of functions that moved to C_Container. Applied C_Container to appropriate calls as necessary.
Removed temporary local override of functions that moved to C_Container. Applied C_Container to appropriate calls as necessary.
Removed temporary local override of functions that moved to C_Container. Applied C_Container to appropriate calls as necessary. Added function ParseItemLink to get the payload of an item link (mainly to get gem information). Fixed texture and gem information. Removed call to Azerite.
Remove locals
Collaborator
|
Hey @GovtGeek , Appreciate this, but can you try it again without so many of the extra files included? I'm adding a few comments as well. Thanks! |
Contributor
Author
|
I'll do my best. Git and I don't seem to get along really well. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have this working in my fork. I don't know how to remove the readme file from the pull request, so you can deny that change.