Trying to make the code more readable#12
Open
ghost wants to merge 1 commit into
Open
Conversation
Owner
|
On 9/2/2017 12:15 PM, flaviommedeiros wrote:
Hi all,
I'm running some C code analysis tool that pointed me to this small code fragment. I'm suggesting this patch to try to make the source code more understandable by removing mixing of ternary if statements with attributions.
Would you guys agree with this type of changes? The tools pointed me to almost 40 cases like this one in the source code of machinekit.
You can view, comment on, or merge this pull request online at:
I'm OK with the original form, but you can send a PR to the Machinekit
repo (https://github.com/machinekit/machinekit) instead of my personal
copy to see what everyone else thinks.
…--
Charles Steinkuehler
charles@steinkuehler.net
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
I'm running some C code analysis tool that pointed me to this small code fragment. I'm suggesting this patch to try to make the source code more understandable by removing mixing of ternary if statements with attributions.
Would you guys agree with this type of changes? The tools pointed me to almost 40 cases like this one in the source code of machinekit.