Skip to content

Conversation

@gnzng
Copy link
Collaborator

@gnzng gnzng commented Mar 2, 2025

This PR will create the docs for every update in the master branch, as it was discussed as an option in #20. I tested it in the master branch of my fork (https://github.com/gnzng/cdtools/actions/runs/13619770916). The build from docs from the workflow can be found here: https://gnzng.github.io/cdtools/

small but import addition for all mac users:

  • a097dd5 adding the hidden MacOS file .DS_Store to the .gitignore

@gnzng
Copy link
Collaborator Author

gnzng commented Mar 2, 2025

I probably went to PR it a little too early, many of the copied files we probably don't need to have them mirrored in the repo.

@gnzng gnzng marked this pull request as draft March 2, 2025 23:05
@gnzng
Copy link
Collaborator Author

gnzng commented Mar 2, 2025

From how it is setup now it can be directly deployed from the actions without saving or uploading the build
image

@allevitan
Copy link
Collaborator

Is there more you'd like to do before we review and merge?

@gnzng
Copy link
Collaborator Author

gnzng commented Mar 6, 2025

I think it is a good start for building and deploying the docs from this repo. I think it would be good to have different doc versions for different published versions (e.g. like numpy does https://numpy.org/doc/2.2/), but I don't have any experience in how to change it in this direction and how much time and effort would be. Ill look into that at some point in time, because it will be useful for another project as well.

@allevitan allevitan marked this pull request as ready for review March 7, 2025 10:12
Copy link
Collaborator

@allevitan allevitan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, to be honest I don't fully understand how github actions work, so my review here is limited to checking that the test version on the tracking branch is working.

But, because this doesn't affect the code, just the docs, I feel safe merging it into master and then dealing with any further issues that appear in a subsequent PR.

Thanks a ton for all this work! I think this is going to be super useful.

@allevitan allevitan merged commit ee7f7ee into cdtools-developers:master Mar 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants