Bugfix/h5 strings #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e for h5_to_nested_dict and nested_dict_to_h5
yoshikisd
reviewed
Mar 19, 2025
yoshikisd
requested changes
Mar 20, 2025
Collaborator
yoshikisd
left a comment
yoshikisd
left a comment
There was a problem hiding this comment.
Overall I think this looks good. Pytests are running fine on my machine. There's a few minor typos on the code description (e.g., the name of the return variable is different from what's on the description) that should be corrected before merging to avoid confusion later on.
I have also included a few optional suggestions to make the code more succinct.
yoshikisd
approved these changes
Mar 20, 2025
Collaborator
yoshikisd
left a comment
yoshikisd
left a comment
There was a problem hiding this comment.
This looks good to me. Pytests are still working on my machine. Let's merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.h5 files saved by "nested_dict_to_h5" would throw an error when "h5_to_nested_dict" was used to read them... it was coming from something to do with how strings were saved and loaded.
I pushed a fix to the code, and I also updated the documentation and added test coverage for these functions and two related functions for nested dicts, nested_dict_to_numpy and nested_dict_to_torch.