Fix an issue for datasets with colinear translations #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue in the calculation of the scaling for the scaled mean diffraction pattern, which would cause a crash whenever dataset.inspect() was called on a dataset with fully colinear scan points. A special case of this which happens a lot is when there is no scanning, or all the scan points are equal in the dataset.
I updated the functions to revert to just displaying the mean pattern in this case, and raising a warning. I also updated the docstrings. I did not add any tests because coverage for the dataset classes is quite sparse and feels like a separate project.
To test this specifically, one can run a modified version of
inspect_dataset.pyfrom the examples: