handling of 64-bit floats in Ptycho2DDataset cxi import #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshikisd
reviewed
Jun 17, 2025
Collaborator
yoshikisd
left a comment
yoshikisd
left a comment
There was a problem hiding this comment.
These changes look great! Pytests work on my machine.
I only have one suggestion on the warning message. Other than that I'd be happy to approve and merge this change after I hear back about your thoughts on the suggestion.
yoshikisd
approved these changes
Jun 17, 2025
Collaborator
yoshikisd
left a comment
yoshikisd
left a comment
There was a problem hiding this comment.
Looks good to me! Let's merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just ran into that issue (see screenshot below). There is no problem in saving and handling
float64is usually not an issue, only when restoring fromfrom_cxi. So I made the following adjustments to transform them tot.float32upon loading with issuing a warning instead of an error.I also reordered the imports for the 2 file I touched.
All tests are passing.