fix(plugin): add missing title and type to userConfig.github_token#691
Merged
fix(plugin): add missing title and type to userConfig.github_token#691
Conversation
Adds the two required fields — "title": "GitHub Token" and "type": "string" — to the github_token entry in plugin.json so claude plugin validate passes without userConfig schema errors. Phase 1 of 1: #690 - Fix plugin.json userConfig schema — missing required type and title fields
Owner
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #690: Fix plugin.json userConfig schema — missing required
typeandtitlefields.typeandtitlefields #690Changes
"title": "GitHub Token"touserConfig.github_tokeninplugin/ralph-hero/.claude-plugin/plugin.json"type": "string"touserConfig.github_tokeninplugin/ralph-hero/.claude-plugin/plugin.jsondescriptionandsensitivefields are unchangedTest Plan
node -e "JSON.parse(require('fs').readFileSync('plugin/ralph-hero/.claude-plugin/plugin.json','utf8'))"exits 0 (valid JSON)claude plugin validate plugin/ralph-heropasses with nouserConfig.github_tokenerrors (the three pre-existing YAML parse errors in skill SKILL.md files are out of scope — separate issue)userConfig.github_tokennow has exactly four keys in order:title,type,description,sensitiveGenerated with Claude Code (Ralph GitHub Plugin)