feat: Implement nested LLM retry configuration via --retries argument#379
Merged
dwash96 merged 4 commits intocecli-dev:v0.96.0from Jan 18, 2026
Merged
Conversation
Co-authored-by: aider-ce (openai/gemini_szmania/gemini-3-flash-preview)
Co-authored-by: aider-ce (openai/openai_gemini_cli/gemini-2.5-pro)
Co-authored-by: aider-ce (openai/openai_gemini_cli/gemini-2.5-pro)
Collaborator
|
How are we feeling on this one? |
Author
|
Just got to tiddy it up. Been a bit busy. Will try to take a look at it soon. If you want to knock it out if you have time, feel free too. |
Author
|
I've updated the PR description to reflect the final implementation details and the nested configuration structure. The logic now correctly handles the |
Collaborator
|
Nice, it's looking good to me! There are conflicts with 0.96.0 but I'll resolve this and add it in the version 🙏 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Implement nested LLM retry configuration via
--retriesargumentThis pull request refactors the LLM retry mechanism from individual top-level arguments into a structured, nested configuration object. This change improves configuration organization and aligns with other nested settings like
agent-config.Key Improvements:
--retry-timeout,--retry-backoff-factor, and--retry-on-unavailableflags with a single--retriesargument..cecli.conf.yml.backoff-factor) and underscore keys (e.g.,retry_timeout), ensuring a seamless transition for users.ServiceUnavailableError, allowing users to opt-in to retries for this specific failure mode.RateLimitError(429).Modelclass initialization and thesend_completionloop, reducing clutter in the main execution path.Example Configuration (
.cecli.conf.yml):Implementation Details:
cecli/args.py: Added the--retriesargument to the "Model settings" group.cecli/main.py: Integratedconvert_yaml_to_json_stringto process the nested retry object from YAML/JSON.cecli/models.py:Model.__init__to parse the nestedretriesconfiguration with support for multiple key formats.send_completionusingasyncio.sleepand exponential backoff.request_timeoutproperty to maintain compatibility with existing tests.