Skip to content

Make --watch-files work in dumb terminals and non-fancy input#455

Merged
dwash96 merged 2 commits intocecli-dev:v0.97.2from
ekr1:main
Mar 3, 2026
Merged

Make --watch-files work in dumb terminals and non-fancy input#455
dwash96 merged 2 commits intocecli-dev:v0.97.2from
ekr1:main

Conversation

@ekr1
Copy link
Copy Markdown

@ekr1 ekr1 commented Feb 23, 2026

Currently, if cecli is run with TERM=dumb and/or --no-fancy-input, the option --watch-files does nothing, because it calls a blocking input method (and does not recognize any kind of interrupts).

This PR changes this behavior so --watch-files works with the dumbest variation, while keeping all other input variations (TUI, fancy) unchanged:

$ TERM=dumb cecli --no-tui --no-fancy-input --watch-files

(In short, --watch-files should now work completely irrespective of any other options.)

It is implemented for Unix/POSIX only, as I have no access to a Windows machine; but if the user tries --watch-files and for some reason the (old) blocking input logic is activated it should fall back gracefully with a helpful warning on Windows.

@dwash96
Copy link
Copy Markdown
Collaborator

dwash96 commented Feb 24, 2026

Ope, very interesting. Can you run the pre-commit hooks and update the tests for this?

@dwash96 dwash96 changed the base branch from main to v0.97.2 March 3, 2026 05:27
@dwash96 dwash96 changed the base branch from v0.97.2 to main March 3, 2026 06:26
@dwash96 dwash96 changed the base branch from main to v0.97.2 March 3, 2026 06:26
@dwash96 dwash96 merged commit bab9ee7 into cecli-dev:v0.97.2 Mar 3, 2026
6 of 12 checks passed
@ekr1
Copy link
Copy Markdown
Author

ekr1 commented Mar 9, 2026

Ope, very interesting. Can you run the pre-commit hooks and update the tests for this?

Thanks for taking care of this, @dwash96. I've been buried in work recently and didn't have a chance to look into this so far. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants