Skip to content

Replace shlex with oslex within grep tool for Windows compatibility #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dwash96 merged 4 commits into from
Oct 25, 2025
Merged

Replace shlex with oslex within grep tool for Windows compatibility #53

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2bda5e9
Recognize pwsh.exe as a valid parent process on Windows.
jamwil Oct 22, 2025
56ff500
Replace shlex.join with simple join.
jamwil Oct 22, 2025
60f05fd
Use oslex instead of shlex.
jamwil Oct 23, 2025
18f80fb
Revert "Recognize pwsh.exe as a valid parent process on Windows."
jamwil Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions aider/tools/grep.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import shlex
import shutil
from pathlib import Path

import oslex

from aider.run_cmd import run_cmd_subprocess


Expand Down Expand Up @@ -117,7 +118,7 @@ def _execute_grep(
cmd_args.extend([pattern, str(search_dir_path)])

# Convert list to command string for run_cmd_subprocess
command_string = shlex.join(cmd_args)
command_string = oslex.join(cmd_args)

coder.io.tool_output(f"⚙️ Executing {tool_name}: {command_string}")

Expand Down
Loading