Refactor: Change show_completion_notification default to False and remove redundant settings#552
Merged
dwash96 merged 11 commits intoJun 4, 2026
Conversation
added 11 commits
June 3, 2026 11:32
Co-authored-by: cecli (openai/gemini_cli_local/gemini-2.5-pro)
Co-authored-by: cecli (openai/gemini_cli_local/gemini-2.5-pro)
Co-authored-by: cecli (openai/gemini_cli_local/gemini-2.5-pro)
Co-authored-by: cecli (openai/gemini_cli_local/gemini-2.5-pro)
Co-authored-by: cecli (openai/gemini_cli_local/gemini-2.5-pro)
…, and copy_context Co-authored-by: cecli (openai/gemini_cli_local/gemini-2.5-pro)
Co-authored-by: cecli (openai/gemini_cli_local/gemini-2.5-pro)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
show_completion_notificationbehavior in Cecli commands:BaseCommandfromTruetoFalseshow_completion_notification = Falsedeclarations from command classesshow_completion_notification = Trueto commands that should show completion notificationsChanges Made
cecli/commands/utils/base_command.pyto setshow_completion_notification = Falseas defaultshow_completion_notification = Falsefrom 34 command classesshow_completion_notification = Trueto 37 command classes that previously relied on the old default/add,/clear,/diff,/copy,/copy_context,/context-blocks,/context-management,/quit,/spawn-agent,/switch-agenttoFalseTruewhere appropriateMotivation
This change simplifies the codebase by removing redundant attribute declarations and makes the default behavior more sensible (most commands don't need to show completion notifications).
Testing
Related Issue
Fixes CLI-44