Fix gitignore pathspec checks to resolve paths against repo root#556
Merged
dwash96 merged 1 commit intoJun 5, 2026
Merged
Conversation
Relative paths passed to _is_gitignored_by_pathspec used Path.resolve() against process cwd, so multi-repo / superproject sessions could falsely mark tracked files as gitignored and reject /add. Co-authored-by: Cursor <cursoragent@cursor.com>
b612d5c to
fcf8876
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitRepo._resolve_path_in_repo()so relative paths are resolved underself.root, not process cwd._is_gitignored_by_pathspec()when walking.gitignorerules.Problem
_is_gitignored_by_pathspeccalledPath(path).resolve()on relative paths. That resolves against the caller’s working directory, not the git repo root. In multi-repo / superproject setups (session cwd at a parent repo,GitReporooted at a submodule), tracked files could be falsely reported as gitignored and/addwould reject them.Example: cecli submodule with whitelist
.gitignore(*+!/cecli/**), cwd at superproject root, pathcecli/helpers/responses.pymis-resolved and matched*.Test plan
/add cecli/cecli/helpers/responses.pysucceeds when cwd is parent repo root