Limited web concurrency for memory constrained environment.#2
Open
federico-bana-cedarcode wants to merge 4 commits intomainfrom
Open
Limited web concurrency for memory constrained environment.#2federico-bana-cedarcode wants to merge 4 commits intomainfrom
federico-bana-cedarcode wants to merge 4 commits intomainfrom
Conversation
Author
|
Merge #1 first. |
santiagorodriguez96
approved these changes
May 8, 2026
Comment on lines
+31
to
+32
| # workers Integer(ENV.fetch("WEB_CONCURRENCY") { Concurrent.physical_processor_count }) | ||
| workers Integer(ENV.fetch("WEB_CONCURRENCY") { 1 }) |
Collaborator
There was a problem hiding this comment.
Tbh honest I'd try to avoid changing this only because of the memory limitations of the server. If anything, we a slightly bigger instance we will be good
| server: localhost:5555 | ||
| server: 864100757851.dkr.ecr.us-east-1.amazonaws.com | ||
| username: AWS | ||
| password: <%= %x(aws ecr get-login-password).strip %> |
Collaborator
There was a problem hiding this comment.
nit: is the strip needed?
Suggested change
| password: <%= %x(aws ecr get-login-password).strip %> | |
| password: <%= %x(aws ecr get-login-password)%> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are running this on a small instance so limiting the amount of memory available to the app and concurrency seemed reasonable.