You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci
This PR adds an optional Neon Postgres database to create-cedar-app via a new --db neon-postgres flag (requires --esm). The previous blocking issues — missing ESM guard, broken path resolution, silent {{DATABASE_URL}} placeholder, and invalid CLI validation — are all resolved in this revision.
Confidence Score: 5/5
Safe to merge; all previously blocking issues are resolved and only minor P2 suggestions remain.
All P0/P1 concerns from prior review rounds are addressed: the CLI validation now correctly accepts neon-postgres, the ESM guard is in place, the fetch error path now throws on non-2xx responses, and the broken prismaVersion() path is replaced with a hardcoded constant. The two remaining findings are P2 style suggestions (hardcoded ref and pinned version without caret).
No files require special attention.
Important Files Changed
Filename
Overview
packages/create-cedar-app/src/project-files.ts
Core logic for neon-postgres overlay: fetches a Neon DB, writes connection string into .env.defaults via placeholder replacement; error path leaves DATABASE_URL empty (user is warned); ref is hardcoded to 'cedarjs'.
packages/create-cedar-app/src/handle-args.ts
Adds handleDatabasePreference() with validation and ESM guard for neon-postgres; addresses the previously flagged missing ESM guard.
Switches @prisma/adapter-pg from hardcoded ^7.5.0 to the {{PRISMA_VERSION}} placeholder, which resolves to 7.6.0 (no caret) at scaffolding time — removing patch-version flexibility for new pglite projects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optionally give the user a Neon database as part of creating a Cedar app